-
Notifications
You must be signed in to change notification settings - Fork 751
Write data returns String? uuid
instead of boolean
#1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add write single health data example - Add write single workout data example
Health 13.1.3
Health 13.1.4
Health 13.1.4
@agilst I'm thinking, the way this is implemented now might result in faster API rate limits on the device, since now you are doing WRITE & READ instead of just WRITE. Wouldn't it make more sense to generate the object before writing and then return it when writing is successful and null otherwise? |
@iarata you're right. At this stage, I don't think generate the object before writing is a good idea as we already have I'll proceed with the changes if you agree. or let me know if you have another suggestion. |
Health 13.2.0
Health 13.2.0
HealthDataPoint?
object instead of booleanString? uuid
instead of boolean
@iarata please kindly review or let me know if you have another suggestion. |
@agilst Thanks for the PR! |
Moved to carp-dk/carp-health-flutter#448. |
IMPORTANT: It is mandatory to merge both #1193 and #1194 before merging this PR as it's depend onmerged.getHealthDataByUUID
method in #1193 and #1194 PRs.writeHealthData
andwriteWorkoutData
is now returnsString? uuid
usingInsertRecordsResponse.recordIdsList.firstOrNull()
on Android andHKObject.uuid.uuidString
on iOS. Please note that there is no extra efforts added when writing health data.This is useful for some apps that need to utilise
uuid
once successfully writing health data (e.g. store into database for future use).