Add rawWorkoutActivityType to WorkoutHealthValue #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klnfreedom Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new field, rawWorkoutActivityType, to the WorkoutHealthValue model. The primary motivation for this addition is to retain the original workout activity type string from the native health data provider (e.g., Apple Health or Google Fit).
Currently, workoutActivityType relies on a predefined HealthWorkoutActivityType enum, which does not cover all possible activity types provided by health platforms. As a result, any unsupported type defaults to HealthWorkoutActivityType.OTHER, leading to loss of information and granularity.
By storing the raw string in rawWorkoutActivityType, we can:
Preserve the exact source activity type for downstream processing or analytics.
Enable future extensions or mappings without data loss.
Improve compatibility with custom or newer activity types not yet reflected in the enum.
This change is backward-compatible and does not affect existing functionality that relies on the enum, while making the system more extensible and robust for real-world data.