Test 'exclude_from_schema' deprecation warning message #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rest_framework/schemas/generators.py
Outdated
| fmt = ("{}. The `APIView.exclude_from_schema` is pending deprecation. " | ||
| "Set `schema = None` instead") | ||
| fmt = ("The `APIView.exclude_from_schema` is pending deprecation. " | ||
| "Set `schema = None` instead in `{}`.") |
There was a problem hiding this comment.
Just before I merge this...
I put the class name first so it would be more obvious in the console.
Last it could be all the way ..................................................................................................................................................................................................................over here.
What do you think?
There was a problem hiding this comment.
That's fair. Maybe APIView.exclude_from_schema => ClassName.exclude_from_schema?
There was a problem hiding this comment.
I mostly made the change b/c the class name on its own read a little oddly.
There was a problem hiding this comment.
OK. Do that and we'll go. 👍
rpkilby
force-pushed
the
deprecate-exclude_from_schema
branch
from
6bb3f25 to
492bb3d
Compare
carltongibson
pushed a commit
that referenced
this pull request
Sep 22, 2017
* Add tests for schema exclusions * Move exclusion check to should_include_endpoint * Update docs * Switch to using `schema = None` * Test PendingDeprecationWarnings * Add note to release notes. * s/deprecated/pending deprecation/ * Add PR link to release notes * Correct typo in test class name * Test 'exclude_from_schema' deprecation warning message (#1) * Correct deprecation warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carltongibson - was just trying to recreate the noise from the deprecation warnings on my machine. In the process, also added assertions for the msg.