Skip to content

Conversation

SteveLauC
Copy link
Contributor

What does this PR do

Update the documentation of RpcSystem

  1. tokio_core has been deprecated, so replace tokio_core::reactor::handle::spawn() with tokio::task::spawn_local().
  2. Explicitly document it that RpcSystem is not Send (so one needs spawn_local() rather than spawn()).

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.64%. Comparing base (b85e041) to head (ab342b3).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   51.84%   51.64%   -0.20%     
==========================================
  Files          69       69              
  Lines       34127    33735     -392     
==========================================
- Hits        17692    17422     -270     
+ Misses      16435    16313     -122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwrensha dwrensha merged commit c9df2bb into capnproto:master May 7, 2024
@dwrensha
Copy link
Member

dwrensha commented May 7, 2024

Thanks!

@SteveLauC SteveLauC deleted the docs/run_RpcSystem branch May 7, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants