feat(file-picker): add persistent ContentUrl functionality to pickFile on Android #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for your PR. I am currently planning to make a complete rewrite of the plugin. For this reason I would like to leave your PR open. However, I keep this issue in mind. |
robingenz
added
platform: android
added 4 commits
September 10, 2024 14:38
…ntent-url-option # Conflicts: # package-lock.json # packages/file-picker/README.md # packages/file-picker/android/src/main/java/io/capawesome/capacitorjs/plugins/filepicker/FilePickerPlugin.java
…ption # Conflicts: # package-lock.json # packages/file-picker/README.md # packages/file-picker/android/src/main/java/io/capawesome/capacitorjs/plugins/filepicker/FilePickerPlugin.java # packages/file-picker/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change reasons
I use the plugin in an app where usage of file picker and consumption of the returned path are not at the same moment. After restarting the app or rebooting the device, the path is invalidated on Android, while it works fine on iOS.
With the provided changes and my little understanding of native Android code, in pickFile(...) it is possible to optionally use a different Intent which grants persistence permission, which will be taken later inside the activity callback.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).