forEach not calling callback on completion?

[apemsel]

Might be a stupid question, but "finished" is never displayed in the following example

var async = require("async");
var sys = require("sys");

var a = ["foo","bar","baz"];

var f = function(arg) {
    sys.log(arg);
}

async.forEach(a, f, function(err) {
    sys.log("finished");
});

[caolan]

The iterator function accepts 'arg' and a callback. After completion it must call the callback. Once all iterators have called their callback the forEach callback is executed... I hope that's clear, because the wording is a bit awkward.

Try updating your example to this:

var async = require("async");
var sys = require("sys");

var a = ["foo","bar","baz"];

var f = function(arg, callback) {
    sys.log(arg);
    callback();
}

async.forEach(a, f, function(err) {
    sys.log("finished");
});

That should now display "finished" :)

[caolan]

Although this is described in the README, the forEach example doesn't really show it. Perhaps the examples could use a bit of an update.

[apemsel]

ahhh thanks, great support ;-)

[apemsel]

forgot to close