fix: Scrollbar should be in the side of the logview

melos.yaml

@@ -60,15 +60,15 @@ scripts:
 
   # run integration tests in all packages
   integration_test: >
-    melos exec -c 1 --fail-fast --dir-exists=integration_test -- \
+    melos exec -c 1 --dir-exists=integration_test -- \
       flutter test integration_test
 
   # runs "flutter pub <arg(s)>" in all packages
   pub: melos exec -c 1 -- flutter pub "$@"
 
   # run tests in all packages
   test: >
-    melos exec -c 1 --fail-fast --dir-exists=test -- \
+    melos exec -c 1 --dir-exists=test -- \
       flutter test
 
   # run pub upgrade in all packages

packages/ubuntu_service/pubspec.yaml

@@ -9,7 +9,7 @@ environment:
   sdk: '>=3.0.0 <4.0.0'
 
 dependencies:
-  get_it: ^7.4.1
+  get_it: '>=7.4.1 <7.6.8'
   meta: ^1.11.0
 
 dev_dependencies:

packages/ubuntu_widgets/lib/src/log_view.dart

@@ -7,20 +7,17 @@ class LogView extends StatefulWidget {
   /// Creates a log view. A stream of [log] lines is required.
   const LogView({
     required this.log,
-    this.maxLines,
     this.padding,
     this.decoration,
     this.background,
     this.style,
+    this.scrollController,
     super.key,
   });
 
   /// The stream of log lines to show.
   final Stream<String> log;
 
-  /// See [TextField.maxLines]
-  final int? maxLines;
-
   /// Padding around the log text.
   final EdgeInsetsGeometry? padding;
 
@@ -33,14 +30,17 @@ class LogView extends StatefulWidget {
   /// See [TextField.style]
   final TextStyle? style;
 
+  /// See [TextField.scrollController]
+  final ScrollController? scrollController;
+
   @override
   State<LogView> createState() => _LogViewState();
 }
 
 class _LogViewState extends State<LogView> {
   StreamSubscription<String>? _subscription;
   final _controller = TextEditingController();
-  final _scrollController = ScrollController();
+  late final _scrollController = widget.scrollController ?? ScrollController();
 
   @override
   void initState() {
@@ -95,16 +95,27 @@ class _LogViewState extends State<LogView> {
 
   @override
   Widget build(BuildContext context) {
-    return Container(
-      padding: widget.padding,
-      decoration: widget.background,
-      child: TextField(
-        controller: _controller,
-        decoration: widget.decoration,
-        maxLines: widget.maxLines,
-        readOnly: true,
-        scrollController: _scrollController,
-        style: widget.style,
+    final contentPadding =
+        (widget.decoration?.contentPadding ?? EdgeInsets.zero)
+            .add(widget.padding ?? EdgeInsets.zero);
+    final decoration = (widget.decoration ?? const InputDecoration())
+        .copyWith(contentPadding: contentPadding);
+
+    return DecoratedBox(
+      decoration: widget.background ?? const BoxDecoration(),
+      child: Scrollbar(
+        key: const ValueKey('LogViewScrollbar'),
+        thumbVisibility: true,
+        controller: _scrollController,
+        child: SingleChildScrollView(
+          controller: _scrollController,
+          child: TextField(
+            controller: _controller,
+            decoration: decoration,
+            readOnly: true,
+            style: widget.style,
+          ),
+        ),
       ),
     );
   }

packages/ubuntu_widgets/test/log_view_test.dart

@@ -9,11 +9,18 @@ import 'package:ubuntu_widgets/ubuntu_widgets.dart';
 void main() {
   testWidgets('append lines', (tester) async {
     final log = StreamController<String>(sync: true);
+    final scrollController = ScrollController();
 
     await tester.pumpWidget(
       MaterialApp(
         home: Scaffold(
-          body: LogView(log: log.stream, maxLines: 2),
+          body: SizedBox(
+            height: 5,
+            child: LogView(
+              log: log.stream,
+              scrollController: scrollController,
+            ),
+          ),
         ),
       ),
     );
@@ -23,26 +30,23 @@ void main() {
     final controller = textField.controller;
     expect(controller, isNotNull);
 
-    final scrollController = textField.scrollController;
-    expect(scrollController, isNotNull);
-
     log.add('line 1');
     await tester.pump();
     expect(controller!.text, equals('line 1'));
-    expect(scrollController!.position.extentAfter, equals(0.0));
-    expect(scrollController.position.maxScrollExtent, equals(0.0));
+    expect(scrollController.position.extentAfter, equals(0.0));
+    expect(scrollController.position.maxScrollExtent, isPositive);
 
     log.add('line 2');
     await tester.pump();
     expect(controller.text, equals('line 1\nline 2'));
     expect(scrollController.position.extentAfter, equals(0.0));
-    expect(scrollController.position.maxScrollExtent, equals(0.0));
+    expect(scrollController.position.maxScrollExtent, isPositive);
 
     log.add('line 3');
-    await tester.pump();
+    await tester.pumpAndSettle();
     expect(controller.text, equals('line 1\nline 2\nline 3'));
     expect(scrollController.position.extentAfter, equals(0.0));
-    expect(scrollController.position.maxScrollExtent, greaterThan(0.0));
+    expect(scrollController.position.maxScrollExtent, isPositive);
   });
 
   testWidgets('rebuild with different stream', (tester) async {
@@ -78,7 +82,14 @@ void main() {
     }
 
     await tester.pumpWidget(
-      MaterialApp(home: Scaffold(body: LogView(log: log.stream, maxLines: 2))),
+      MaterialApp(
+        home: Scaffold(
+          body: SizedBox(
+            height: 20,
+            child: LogView(log: log.stream),
+          ),
+        ),
+      ),
     );
 
     FlutterErrorDetails? error;
@@ -99,7 +110,7 @@ void main() {
     await tester.pumpWidget(
       MaterialApp(
         home: Scaffold(
-          body: LogView(log: log.stream, maxLines: 2),
+          body: SizedBox(height: 20, child: LogView(log: log.stream)),
         ),
       ),
     );
@@ -109,7 +120,9 @@ void main() {
     final controller = textField.controller;
     expect(controller, isNotNull);
 
-    final scrollController = textField.scrollController;
+    final scrollView = tester
+        .widget<SingleChildScrollView>(find.byType(SingleChildScrollView));
+    final scrollController = scrollView.controller;
     expect(scrollController, isNotNull);
 
     for (var i = 1; i < 6; i++) {