[DPE-8916] Use mysql-shell-client package #727
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
added
the
enhancement
github-actions
bot
added
the
Libraries: Out of sync
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
15 times, most recently
from
770c1c2 to
045ea49
Compare
paulomach
reviewed
Dec 16, 2025
Contributor
paulomach
left a comment
paulomach
left a comment
There was a problem hiding this comment.
Great work, I like the direction this is going.
out of a couple comments just one is a blocker (about admin port), otherise lgtm
| @@ -723,12 +731,14 @@ def cluster_initialized(self) -> bool: | |||
| if not self.app_peer_data.get("cluster-name"): | |||
| return False | |||
|
|
|||
| if self.unit_initialized(): | |||
| return True | |||
|
|
|||
lib/charms/mysql/v0/mysql.py
Outdated
| if host and ":" in host: | ||
| # strip port from address | ||
| host = host.split(":")[0] | ||
| def _build_cluster_tcp_executor(self, host: str, port: int = 3306) -> BaseExecutor: |
Contributor
There was a problem hiding this comment.
Why not use ADMIN_PORT for cluster executor?
Contributor
Author
There was a problem hiding this comment.
No real reason apart from: it has not been used for the clusteradmin user so far. Do you recall any reason why this was not the case? Maybe the cluster-admin user was not present on old versions of the charm? 🤔
Contributor
There was a problem hiding this comment.
It was, but we were not doing much with it. In any case, we should use admin port, we don't want some cluster action to fail because we cannot connect to the a host
| self.stop_mysql_exporter() | ||
| self.connect_mysql_exporter() | ||
|
|
||
| def _run_mysqlsh_script( |
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
9 times, most recently
from
6dc8195 to
8a51924
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
2 times, most recently
from
7be5170 to
f4c00a9
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
from
f4c00a9 to
c443f86
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
from
163237c to
f56cff9
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
from
f56cff9 to
608ef38
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
from
608ef38 to
f529cf5
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
from
f529cf5 to
44c9dd5
Compare
sinclert-canonical
force-pushed
the
sinclert/8916/mysql-shell-client
branch
from
44c9dd5 to
4f3d6e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a whole horizontal slice of the charm code, to rely on mysql-shell-client package.
Exceptions to this extraction are:
Highlights:
Removed.lock_instanceargument fromadd_instance_to_clustercharm lib functionRemoved.lock_instanceargument fromremove_instance_to_clustercharm lib functionReview strategy
Given the amount of changes proposed on this PR, I recommend reviewing commit by commit. When reaching 3d32f6f, please compared side-by-side:
mysqlcharm lib.mysqlcharm lib.