Skip to content

Conversation

@fernando79513
Copy link
Collaborator

Description

There were some devices that were failing the camera quality tests by a small margin after changing the downscaling algorithm. After checking the images that failied in the las SRUs (and checking the results for ~100 successfull submissions), I think it’s safe to increase the threshold to form 60 to 70, since most of the submissions in that bracket have an okay image quality, but there are few features to detect, and we are still able to detect very bad images, or devices with the shutter off:

Brisque score: 62
6c347a05-7a3d-4162-94bb-8311b1e95ebd

Brisque score: 64
574cc0a5-e745-4564-b300-a9035134b7c8

Brisque score: 65
bfbc48b1-4e0a-4b8f-8a52-1d221b13a9d5

Brisque score: 92
d842ccea-0210-4424-a544-ae681ba204c6

Resolved issues

#1660

Documentation

Tests

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.66%. Comparing base (c8293fa) to head (a43824a).
⚠️ Report is 99 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2060   +/-   ##
=======================================
  Coverage   51.66%   51.66%           
=======================================
  Files         386      386           
  Lines       41492    41492           
  Branches     7711     7711           
=======================================
  Hits        21435    21435           
  Misses      19293    19293           
  Partials      764      764           
Flag Coverage Δ
provider-base 26.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hook25 Hook25 merged commit fec2b5c into main Aug 1, 2025
24 checks passed
@Hook25 Hook25 deleted the increase-camera-quality-threshold branch August 1, 2025 15:31
stanley31huang pushed a commit that referenced this pull request Aug 14, 2025
increased camera quality threshold
bladernr pushed a commit that referenced this pull request Aug 28, 2025
increased camera quality threshold
stanley31huang pushed a commit that referenced this pull request Oct 3, 2025
increased camera quality threshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants