-
Notifications
You must be signed in to change notification settings - Fork 70
Add new randr cycle script for wayland (New) #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4bfe985 to
4c6f8b7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
+ Coverage 51.21% 52.03% +0.81%
==========================================
Files 386 389 +3
Lines 41697 41862 +165
Branches 7752 7781 +29
==========================================
+ Hits 21357 21784 +427
+ Misses 19577 19304 -273
- Partials 763 774 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GabrielChenCC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The PR content is detailed, easy to read, clear and correct. Thanks @hanhsuan
1643a2d to
45e2820
Compare
…ckbox support that using dbus to control directly.
0e66914 to
1b47c52
Compare
|
I've followed the changes of #1916 to modify my code and unit test. |
GabrielChenCC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanhsuan LGTM. Thanks.
p-gentili
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks already good, but I proposed some changes to make it look easier to read.
Also: after you update the test cases to make use of this script, will we be able to finally get rid of gnome-randr from Checkbox?
Co-authored-by: Paolo Gentili <[email protected]>
2. Moving filter logic to smaller functions
|
p-gentili
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks for the changes!
* This new script is using the functionality of display_info in the checkbox support that using dbus to control directly. --------- Co-authored-by: Paolo Gentili <[email protected]>
Description
This new script is using the functionality of
display_infoin the checkbox support that using dbus to control directly.The test cases modification will be in the follow up PR:
Resolved issues
This is a followup PR for
#855
and fix
#370
Documentation
Tests
24.04:
https://certification.canonical.com/hardware/202001-27667/submission/437591/