Skip to content

fix proposed by @benzman81 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

fix proposed by @benzman81 #64

merged 1 commit into from
Mar 30, 2020

Conversation

shcheuk
Copy link
Contributor

@shcheuk shcheuk commented Mar 28, 2020 •
edited
Loading

#56

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@Trancever
Copy link
Contributor

Thanks!

@Trancever Trancever merged commit 9587d01 into callstack:master Mar 30, 2020
@stazrad
Copy link

stazrad commented Mar 31, 2020 •
edited
Loading

@Trancever did this get shipped? I'm still seeing this error on 2.3.0 😣 sorry- just needed to pod install & rebuild in xcode

TimMun pushed a commit to TimMun/react-native-image-editor that referenced this pull request Sep 11, 2021
@shcheuk
fix: migrate to new way of requiring native modules on iOS side (call…
9bef063 
…stack#64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Trancever Trancever Trancever approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shcheuk @Trancever @stazrad