fix(shard-distributor): remove trimming of prefixes #7490
Merged
+57
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleonoradgr
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: edigregorio <[email protected]>
Signed-off-by: edigregorio <[email protected]>
eleonoradgr
force-pushed
the
test-trimming-removal
branch
from
b502984 to
7347d3a
Compare
gazi-yestemirova
approved these changes
Nov 26, 2025
gazi-yestemirova
pushed a commit
to gazi-yestemirova/cadence
that referenced
this pull request
Nov 28, 2025
…#7490) <!-- Describe what has changed in this PR --> **What changed?** Reverting the trimprefix since we are using constants to compare the values that include that <!-- Tell your future self why have you made these changes --> **Why?** Constants that include the prefix are used to <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** Deployed in staging <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** Corruption of db, which is already the case. <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** --------- Signed-off-by: edigregorio <[email protected]> Signed-off-by: Gaziza Yestemirova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Reverting the trimprefix since we are using constants to compare the values that include that
Why?
Constants that include the prefix are used to
How did you test it?
Deployed in staging
Potential risks
Corruption of db, which is already the case.
Release notes
Documentation Changes