Skip to content

Add Ruff #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Add Ruff #227

merged 5 commits into from
Jan 19, 2023

Conversation

shikanime
Copy link
Contributor

Ruff is a Python linter that is starting to get a lot of attention lately.

@shikanime shikanime marked this pull request as ready for review January 13, 2023 13:36
@shikanime
Copy link
Contributor Author

Oh, at the moment, it seems that Ruff is only available on Nixpkgs version 22.11.

@domenkozar
Copy link
Member

I'll try to bump checks to 22.11

@domenkozar
Copy link
Member

If you rebase it should work now

@domenkozar domenkozar merged commit 53e7669 into cachix:master Jan 19, 2023
@dhess
Copy link

dhess commented Jan 22, 2023

FYI, I believe this commit broke the flake. We now get:

error: Function called without required argument "ruff" at /nix/store/lvwknwz9wfx66qyxdcak5p6w2wfxlzpd-source/nix/tools.nix:32, did you mean "duff", "guff" or "rufo"?

@shikanime
Copy link
Contributor Author

Please correct me if I'm wrong, as the package is only available in 22.11 release, should I have added a default to null ?

@dhess
Copy link

dhess commented Jan 23, 2023

@shikanime Possibly. This happens when I use pre-commit-hooks.nix with haskell.nix, which is, I believe, using a pre-22.11 nixpkgs-unstable pin. There's a PR to bump it: input-output-hk/haskell.nix#1815

Also, we're using follows like so with the haskell.nix nixpkgs:

pre-commit-hooks-nix.inputs.nixpkgs.follows = "nixpkgs";

so this probably wasn't something you tested for.

@shikanime
Copy link
Contributor Author

shikanime commented Jan 23, 2023

Thanks for the extra details, I didn't realize the follows mechanism worked like that after reading the documentation.
Sorry for the inconveniences (⁠。⁠ŏ⁠﹏⁠ŏ⁠)

@dhess
Copy link

dhess commented Jan 23, 2023

No worries at all, thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants