serde improvements #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d is_digit/is_ascii_digit
Contributor
Author
|
bump on this? anything i can do to help this along? |
2 tasks
|
Any recent progress on this PR ? |
Contributor
Author
|
hello. friendly ping. last commit was november 2022, is this project dead / in need of help? PR is almost 2 months old. thanks! |
Contributor
Author
|
@hyunsik sorry to be a bother, but anyway to get this PR and new version for this? thanks |
Member
|
@joeroback Hi, I'm very sorry for late. I'll review it tomorrow. |
hyunsik
approved these changes
Feb 24, 2023
Member
hyunsik
left a comment
hyunsik
left a comment
There was a problem hiding this comment.
The patch looks great to me. I'm sorry again for a late review.
Member
|
@joeroback I've just released out the new version. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #27