Skip to content

Conversation

@esoterra
Copy link
Contributor

Implements #244

Folders are now organized in a consistent way that makes it clear which crates are generators and whether each generator is host/guest. Renames crates to match the new folder names and updates the associated usages and feature flags.

Kyle Brown and others added 8 commits August 15, 2022 13:10
Fix feature flagging in test-helpers
Improve documentation
Other minor fixes
update readme
improve help text
@esoterra
Copy link
Contributor Author

This is ready for review, except the README.md changes, which I'm still working on.

@esoterra esoterra mentioned this pull request Aug 18, 2022
@alexcrichton
Copy link
Member

This all seems reasonable enough to me but I think it would be good to get some other eyes on this as well. @peterhuene you're likely interested in this since you've been working a lot with the rust-to-component stuff recently. Additionally @sunfishcode or @kulakowski-wasm y'all may also be interested in weighing in on the particulars here.

@sunfishcode
Copy link
Member

The new naming here makes sense to me!

@esoterra
Copy link
Contributor Author

Ready on my end.

I'd recommend keeping "releases" / version bumps separate from feature impl PRs.
So if we want to bump to 0.3.0 after this, which I think would be a good idea, I'll make a new PR after.

@sunfishcode
Copy link
Member

Sounds like there are no strong objections, so let's merge this, and iterate from here if there are any follow-up concerns.

@sunfishcode sunfishcode merged commit a4a138b into bytecodealliance:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants