wit-component: emit function type encodings first. #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that components encoded with `wit-component` have the function types from the exports encoded before the instance types for instance imports. Previously, if an instance import defined a type it would be inserted into a map tracking duplicate types and not exported; when the default interface was later processed with a matching type, the type index was reused without adding an export for the type. By encoding export function types first, it guarantees that the default exported interface has its named types exported.
alexcrichton
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that components encoded with
wit-componenthave thefunction types from the exports encoded before the instance types for instance
imports.
Previously, if an instance import defined a type it would be inserted
into a map tracking duplicate types and not exported; when the default
interface was later processed with a matching type, the type index was reused
without adding an export for the type.
By encoding export function types first, it guarantees that the default
exported interface has its named types exported.