Fix some minor bugs in the WIT parser #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The parser would previously panic on empty doc comments (`/**/`), since it would interpret the `/**` as the start of a doc comment, leaving the block comment with `/` instead of `*/` at the end and tripping an assertion. - The parser would panic on `.md` files, since it assumed they were `.wit.md` files and tried to strip the nonexistent `.wit`. - The parser would panic if the input path did not end in a file. I found these while trying out `cargo fuzz`.
Member
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/**/), since it would interpret the/**as the start of a doc comment, leaving the block comment with/instead of*/at the end and tripping an assertion..mdfiles, since it assumed they were.wit.mdfiles and tried to strip the nonexistent.witfrom the filename. I worked around this by changing the parser to take everything before the first.as the name of the interface.I found these while trying out
cargo-fuzz.