wit-component: clean up type exports. #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors encoding in `wit-component` to only export types from the default interface and stop exporting types from instance types used in imports. It also makes "type only" encodings more explicit with `InterfaceEncoder` that will encode the types from a single interface only.
peterhuene
force-pushed
the
suppress-type-exports
branch
from
887c413 to
ae804f1
Compare
peterhuene
changed the title
wit-component output.
Member
Author
|
@alexcrichton I've changed this PR to continue to export types from |
alexcrichton
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors encoding in
wit-componentto only export types from thedefault interface and stop exporting types from instance types used in imports.
It also makes "type only" encodings more explicit with
InterfaceEncoderthatwill encode the types from a single interface only.