Skip to content

Conversation

@7sDream
Copy link
Contributor

@7sDream 7sDream commented Jul 10, 2022

Updates:

  • delete [ in operators since we do not have this token
  • delete _ and A-Z from identifier since we force kebab case now
  • add a sentence to make it clear that id is short for identifier
  • add unit in ty
  • remove _ in expected since we do not support this grammer anymore

In current parse impl, ty has a 'handle' id variant but behavor as same as id for resource type, it seems handle is deprecated?
I just ignore it for now.

@alexcrichton
Copy link
Member

Looks good to me, thanks!

@alexcrichton alexcrichton merged commit 7b7625a into bytecodealliance:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants