Skip to content

Conversation

@alexcrichton
Copy link
Member

This fixes an issue where some structures of "anonymous" types such as
results/etc would accidentally only place types in the C implementation
files instead of the header files where they were needed.

Closes #194

This fixes an issue where some structures of "anonymous" types such as
results/etc would accidentally only place types in the C implementation
files instead of the header files where they were needed.

Closes bytecodealliance#194
Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@alexcrichton alexcrichton merged commit 8aa2b37 into bytecodealliance:main Apr 22, 2022
@alexcrichton alexcrichton deleted the fix-c branch April 22, 2022 00:02
willemneal pushed a commit to theahaco/wit-bindgen that referenced this pull request May 31, 2022
This fixes an issue where some structures of "anonymous" types such as
results/etc would accidentally only place types in the C implementation
files instead of the header files where they were needed.

Closes bytecodealliance#194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Returning a result of an option and error does not generate all structs for the C import bindgen

3 participants