Sort exported functions first in Resolve
#1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sorts `Resolve::exports` a bit more to place exported functions first. While not strictly necessary this makes it easier for bindings generators to consume because it means they'll visit exported functions first before exported interfaces, meaning that any references to types will be more likely to reach the imported interfaces they refer to, which is what's expected.
dicej
approved these changes
Sep 26, 2023
dicej
added a commit
to bytecodealliance/componentize-py
that referenced
this pull request
Sep 28, 2023
This requires bytecodealliance/wasm-tools#1226 and an updated Wasmtime to pull in bytecodealliance/wasm-tools#1218, which means pointing to bleeding-edge git dependencies for the time being.
dicej
added a commit
to bytecodealliance/componentize-py
that referenced
this pull request
Sep 28, 2023
This requires bytecodealliance/wasm-tools#1226 and an updated Wasmtime to pull in bytecodealliance/wasm-tools#1218, which means pointing to bleeding-edge git dependencies for the time being.
dicej
added a commit
to bytecodealliance/componentize-py
that referenced
this pull request
Sep 28, 2023
* implement resource support This requires bytecodealliance/wasm-tools#1226 and an updated Wasmtime to pull in bytecodealliance/wasm-tools#1218, which means pointing to bleeding-edge git dependencies for the time being. * fix clippy warning Signed-off-by: Joel Dice <[email protected]> --------- Signed-off-by: Joel Dice <[email protected]>
dicej
added a commit
to dicej/jco
that referenced
this pull request
Oct 17, 2023
This is to support resource handle lifting and lowering from the guest's point-of-view. Unlike with the other, structural data types, resource bindings must be either host- or guest-specific (i.e. the bindings are not symmetric). I'll follow this up with a `componentize-js` PR that includes a bunch of tests. Note that I had to update several dependencies to pull in bytecodealliance/wasm-tools#1218, which addresses the case of a WIT world that `use`s a resource from an interface while also exporting the interface. Signed-off-by: Joel Dice <[email protected]>
guybedford
pushed a commit
to bytecodealliance/jco
that referenced
this pull request
Oct 17, 2023
* resource support for `componentize-js` This is to support resource handle lifting and lowering from the guest's point-of-view. Unlike with the other, structural data types, resource bindings must be either host- or guest-specific (i.e. the bindings are not symmetric). I'll follow this up with a `componentize-js` PR that includes a bunch of tests. Note that I had to update several dependencies to pull in bytecodealliance/wasm-tools#1218, which addresses the case of a WIT world that `use`s a resource from an interface while also exporting the interface. Signed-off-by: Joel Dice <[email protected]> * fix test regressions Signed-off-by: Joel Dice <[email protected]> --------- Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sorts
Resolve::exportsa bit more to place exported functions first. While not strictly necessary this makes it easier for bindings generators to consume because it means they'll visit exported functions first before exported interfaces, meaning that any references to types will be more likely to reach the imported interfaces they refer to, which is what's expected.