Remove ZStr and ZString.
#337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This also removes the need for several scary |
sunfishcode
force-pushed
the
sunfishcode/remove-zstr
branch
from
5116523 to
6da94be
Compare
sunfishcode
added
the
semver bump
Use `CStr` and `CString` instead, now that nightly has then in core and alloc, respectively. Fixes #336.
--no-default-features disables "std", and building without "std" will require nightly now.
sunfishcode
force-pushed
the
sunfishcode/remove-zstr
branch
from
503ef01 to
f83f5b1
Compare
cgwalters
approved these changes
May 27, 2022
Contributor
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Makes sense to me; one less string type to keep in mind is good overall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CStrandCStringinstead, now that nightly has then in core andalloc, respectively.
Fixes #336.