feat: wasi p3 async support for jco #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
3 times, most recently
from
2b33a98 to
708cd3b
Compare
|
Just a note -- I'm rolling the upgrade to tooling version 227.1 here -- the upgrade seems to have broken some things on the jco side, right now the remaining errors are:
|
|
@vados-cosmonic please create a separate PR for the 227.1 upgrade path for direct review and testing, that way I can also more easily assist. |
|
Ah apologies for the noise, will pull out that update into a new PR, thanks (in advance) for the help @guybedford 🙇 |
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
4 times, most recently
from
82dafa1 to
d04011a
Compare
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
3 times, most recently
from
db7408d to
a812534
Compare
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
2 times, most recently
from
9b43d49 to
c29e93e
Compare
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
5 times, most recently
from
3aab70e to
59cf305
Compare
|
OK, so I had to make a couple concessions here:
|
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
8 times, most recently
from
1fbcbb5 to
87ce320
Compare
This commit adds initial support for async component model features with the error-context intrinsics. Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
feat=p3-async-support
branch
from
1f75ac4 to
d3e225e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is almost certain to be long lived, and contains the ongoing p3 async support for
To understand this PR, see the following other resources:
Current ongoing implementation in
wasmtimeis over here:wasmtime)Particularly useful from the upstream repos are the test programs that show usage of the new async APIs from the only language with support at present (Rust):
async_error_context.rswhich is one of the fixtures we add and use.