Fix "IsVoid" anti-piracy detection #416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luludotdev
requested changes
Nov 20, 2021
| { | ||
| string directory = App.BeatSaberInstallDirectory; | ||
| string pluginsDirectory = Path.Combine(directory, "Beat Saber_Data", "Plugins"); | ||
| string pluginsDirectory = Path.Combine(directory, "Beat Saber_Data", "Plugins", "x86_64"); // newer version of bs use x86_64 for plugins folder |
Collaborator
There was a problem hiding this comment.
Instead of changing the plugins directory it would be best if ModAssistant checks both, since it can be used on older versions of the game too.
Member
|
This was fixed in #456. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix two bugs:
A recent(?) update to Beat Saber moved all native plugins into an x86_64 subdirectory, breaking ModAssistant's detection.
Certain Windows systems will create an all-uppercase DESKTOP.INI file, causing false flags as ModAssistant previously only checked for lowercase desktop.ini.
(Also a note for the devs: have you considered removing the checks? It seems trivial to bypass, false flags can happen as not every ini is a keygen, and the company that owns Beat Saber is Facebook...)