10X performance improvement by re-using iframe #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glutamate
pushed a commit
to saltcorn/saltcorn
that referenced
this pull request
Jun 22, 2024
* added vm-browserify code as explicit mock * added cached iframe see #20 - browserify/vm-browserify#20 * copy my vm mock before calling webpack * clear content div before navigation - this stops all running scripts in the iframe - sometimes background scripts delay the actual navigation
warren-bank
added a commit
to warren-bank/fork-vm-browserify
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6 & #19.
Re-using the iFrame boosted the performance significantly.
The implementation:
iframe.iframeis left clean after use.Passed all tests, run as described in #11.
I have an application that calls
vm.runInNewContext100's of time per display loop. Recreating and inserting theiframeis killing performance. Much better with a cachediframe