Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .airtap.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
browsers:
- name: chrome
version: 27..latest
version:
- 49 # last supported on XP (keep it so long as it's easy to support)
- -1..latest
- name: firefox
version: latest
version:
- 52 # extended support release
- -1..latest
- name: safari
version: latest
version: -1..latest
- name: ie
version: 9..latest
sauce_connect: true
Expand Down
9 changes: 7 additions & 2 deletions test/node/callbackify.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ var assert = require('assert');
var callbackify = require('../../').callbackify;
var execFile = require('child_process').execFile;

if (typeof Promise === 'undefined') {
console.log('no global Promise found, skipping callbackify tests');
return;
}

var values = [
'hello world',
null,
Expand Down Expand Up @@ -72,7 +77,7 @@ if (typeof Symbol !== 'undefined') {
assert.strictEqual(err.message, 'Promise was rejected with a falsy value');
assert.strictEqual(err.reason, value);
} else {
assert.strictEqual(String(value).endsWith(err.message), true);
assert.strictEqual(String(value).slice(-err.message.length), err.message);
}
} else {
assert.strictEqual(err, value);
Expand All @@ -97,7 +102,7 @@ if (typeof Symbol !== 'undefined') {
assert.strictEqual(err.message, 'Promise was rejected with a falsy value');
assert.strictEqual(err.reason, value);
} else {
assert.strictEqual(String(value).endsWith(err.message), true);
assert.strictEqual(String(value).slice(-err.message.length), err.message);
}
} else {
assert.strictEqual(err, value);
Expand Down
4 changes: 2 additions & 2 deletions util.js
Original file line number Diff line number Diff line change
Expand Up @@ -691,8 +691,8 @@ function callbackify(original) {
// In true node style we process the callback on `nextTick` with all the
// implications (stack, `uncaughtException`, `async_hooks`)
original.apply(this, args)
.then(function(ret) { process.nextTick(cb, null, ret) },
function(rej) { process.nextTick(callbackifyOnRejected, rej, cb) });
.then(function(ret) { process.nextTick(cb.bind(null, null, ret)) },
function(rej) { process.nextTick(callbackifyOnRejected.bind(null, rej, cb)) });
}

Object.setPrototypeOf(callbackified, Object.getPrototypeOf(original));
Expand Down