feat: don't close new opened tabs #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add live page proxy that dynamically tracks the focused page - Implement context event listener to initialize new pages automatically - Remove automatic tab closing behavior in act_handler_utils and cua_handler - Keep both original and new tabs open when new pages are created - Ensure stagehand.page always references the current active page This implementation matches the behavior of browserbase/stagehand#844
arunpatro
changed the title
|
this will close #131 |
miguelg719
reviewed
Jul 25, 2025
miguelg719
reviewed
Jul 25, 2025
miguelg719
added a commit
that referenced
this pull request
Aug 9, 2025
* feat: don't close new opened tabs (#161) * feat: port new page handling from JS Stagehand PR #844 - Add live page proxy that dynamically tracks the focused page - Implement context event listener to initialize new pages automatically - Remove automatic tab closing behavior in act_handler_utils and cua_handler - Keep both original and new tabs open when new pages are created - Ensure stagehand.page always references the current active page This implementation matches the behavior of browserbase/stagehand#844 * Update stagehand/handlers/cua_handler.py * Update stagehand/handlers/act_handler_utils.py --------- Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Miguel <[email protected]> * formatting, logs * changeset * fix: update mock_stagehand_client fixture to set internal page properties The page property is now read-only (returns LivePageProxy), so tests need to set the internal _original_page and _active_page properties instead * feat: add page stability check to LivePageProxy for async operations Ensures async operations wait for any pending page switches to complete * formatting * fix: prevent deadlock in page navigation and add page stability tests - Initialize _page_switch_lock in Stagehand constructor - Skip page stability check for navigation methods (goto, reload, go_back, go_forward) - Use lock when switching active pages in context - Add comprehensive tests for LivePageProxy functionality * consolidate original and active page to just one page * Update stagehand/context.py * Update .changeset/gorilla-of-strongest-novelty.md * timeouts * python 3.10 or less compatibility --------- Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Arun Patro <[email protected]> Co-authored-by: Filip Michalsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Feature Parity from JS -> Python: #131
why
what changed
test plan