Skip to content

fix: support ubuntu 24 #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2025
Merged

fix: support ubuntu 24 #620

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f14a724
fix: add dependencies for Ubuntu 24
ueokande Jan 25, 2025
9989ad2
fix: check if ubuntu version is greater than or equal to 24
ueokande Jan 25, 2025
c728050
fix: apply linting rules
ueokande Jan 25, 2025
80787c3
fix: add t64 suffix to ubuntu 24 packages
ueokande Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions src/dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,25 @@ const DEBIAN_BASED_DEPENDENT_PACKAGES = [
"xdg-utils",
];

const UBUNTU_24_DEPENDENT_PACKAGES = [
"libasound2t64",
"libatk-bridge2.0-0t64",
"libatk1.0-0t64",
"libcairo2",
"libcups2t64",
"libdbus-1-3",
"libexpat1",
"libgbm1",
"libglib2.0-0t64",
"libnss3",
"libpango-1.0-0",
"libxcomposite1",
"libxdamage1",
"libxfixes3",
"libxkbcommon0",
"libxrandr2",
];

const FEDORA_BASED_DEPENDENT_PACKAGES = [
"alsa-lib",
"atk",
Expand Down Expand Up @@ -64,23 +83,26 @@ const installDependencies = async (
}

const packages = await (async () => {
const osReleaseId = await runtime.getOsReleaseId();
switch (osReleaseId) {
const { ID: id, VERSION_ID: versionId } = await runtime.loadOsRelease();
switch (id) {
case "rhel":
case "centos":
case "ol":
case "fedora":
return FEDORA_BASED_DEPENDENT_PACKAGES;
case "debian":
case "ubuntu":
case "linuxmint":
return DEBIAN_BASED_DEPENDENT_PACKAGES;
case "ubuntu":
return Number.parseInt(versionId.split(".")[0], 10) >= 24
? UBUNTU_24_DEPENDENT_PACKAGES
: DEBIAN_BASED_DEPENDENT_PACKAGES;
case "opensuse":
case "opensuse-leap":
case "sles":
return SUSE_BASED_DEPENDENT_PACKAGES;
}
throw new Error(`Unsupported OS: ${osReleaseId}`);
throw new Error(`Unsupported OS: ${id}`);
})();
const sudo = !noSudo && process.getuid?.() !== 0;

Expand Down
Loading