-
-
Notifications
You must be signed in to change notification settings - Fork 47
Sqm Correction UI #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sqm Correction UI #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- still has the bias frames, will be removed next commit - added bortle descriptions in the ui
- PNG Processing: Changed sweep to save 8-bit processed PNGs using capture() method - GPS Time Integration: Sweep now uses GPS datetime from shared_state - Altitude Calculation: Added automatic altitude calculation from RA/Dec - Metadata Saving: Implemented comprehensive metadata saving with save_sweep_metadata.py - Progress Bar Fix: Updates progress for every image (not every 10th) - Background Clamping: Modified SQM calculator to clamp negative backgrounds to 1 ADU - Type Hints: Added proper Optional[] type hints for mypy compliance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Cedar-detect shared memory fix: - Fixed intermittent FileNotFoundError when cedar-detect has shared memory issues - Client now gracefully handles missing/stale shared memory - Automatically falls back to non-shmem mode instead of crashing - Updated tetra3 submodule with robust error handling Variable shadowing fix: - Fixed linter error where 'time' variable shadowed 'time' module import - Renamed to 'obs_time' for clarity in altitude calculation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Problem:
- Exposure sweep showed "Capturing... ~20 sec" message for 3 seconds then quit
- UI returned to previous screen while sweep continued in background for ~20s
- User had no visibility into actual progress
Solution:
- Created new UIExpSweep module that shows real-time progress
- Monitors console_queue for "CAM: Sweep X/Y" progress messages
- Shows elapsed time and current progress
- Auto-exits when sweep completes ("CAM: Sweep done!")
- Updated capture_exposure_sweep() callback to push UIExpSweep onto stack
Now users see:
- Live progress counter (e.g., "Sweep 47/100")
- Elapsed time
- Automatic exit when complete
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.