Camera auto exposure #356
Camera auto exposure #356
Conversation
This reverts commit c872394.
python/PiFinder/auto_exposure.py
Outdated
| detected during plate solving, targeting an optimal count for | ||
| reliable solving performance. | ||
| Attributes: |
There was a problem hiding this comment.
Double description, see init below
| self._integral = 0.0 | ||
| self._last_error: Optional[float] = None | ||
|
|
||
| logger.info( |
There was a problem hiding this comment.
Relatively high log level, isn‘t it? I believe these need to be tuned down once the feature becomes stable.
| self.exposure_time = int(exp_value) | ||
| self.set_camera_config(self.exposure_time, self.gain) | ||
| # Update config to reflect manual exposure value | ||
| cfg.set_option("camera_exp", self.exposure_time) |
There was a problem hiding this comment.
Would it make sense to store the PID parameters in config, here?
| # Manual exposure adjustments disable auto-exposure | ||
| self._auto_exposure_enabled = False | ||
| if command == "exp_up": | ||
| self.exposure_time = int(self.exposure_time * 1.25) |
There was a problem hiding this comment.
This sets strange ‚in between‘ exposure times, if I am not mistaken and not those from the selection list in menu_structure, if auto exposure has been on before. Should the code go to nearest setting here? It also seems that the cam driver selects an exposure that is supported by the camera. What about gain?
|
Love this upcoming feature! |
|
This is one of the more exciting features we've had added in a while! Thanks @mrosseel for the work on this. I'm excited to get this tested a bit more and released 🙌 |
3 participants
TODO: