Gemspec: drop EOL'd rubyforge_project, has_rdoc

[olleolleolle]

Summary

The RubyGems gemspec property rubyforge_project has been removed without a replacement. Same with has_rdoc, which now always defaults to true.

Source code location with the deprecation

Checklist

• Added changelog entry (no, this is a trivial change)
• Ran unit tests (rake test:unit) (hoping CI will do this)

[hollabaq86]

Did a little research on this. Looks like RubyForge has been dead since 2014.

Doing a bit of digging on the has_rdoc deprecation, it looks like devs are encountering a deprecation warning as they update to Rails 6, and this was removed from gemspecs december of last year.

I'm still wary of merging this into the next minor release... maybe we hold on this PR until the next major version update.

[olleolleolle]

Background

• RubyForge was closed down in 2013.
• rubygems/rubygems#2436 deprecated the rubyforge_project property.

[crookedneighbor]

@olleolleolle updated your ruby gems pr link to a working link (it was formatted as a relative link)

I agree with Holly that we can safely remove the rubyforge stuff, but the has_rdoc stuff will need to wait for a new major version of the SDK. The way I'm reading it, it's possible for a merchant to be using an old version of rubygems where it wouldn't respect the deprecation.

I'm no expert though, would love to hear more about this if that's not the case.

[crookedneighbor]

Let's replace:

s.has_rdoc = false

with

# NEXT_MAJOR_VERSION remove this attribute as it is deprecated in the latest version of Rubygems
s.has_rdoc = false

[olleolleolle]

It has been 10 years since that thing was deprecated. We're not moving too fast, I think. But, it's your project. I'll make the change to the PR, using the pen.

https://blog.rubygems.org/2009/05/04/1.3.3-released.html

[crookedneighbor]

I think I misunderstood the purpose of the has_rdoc attribute. Since it only matters when publishing to Rubygems, it is safe to remove.

(I thought the enduser also interacted with it in some way with old versions of Rubygems, but that doesn't seem to be the case)

I'll remove it and merge this PR. Thanks!