-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Labels
enhancementNew feature or requestNew feature or requestrequires BOUT changesMay require changes to BOUT++ upstream to implementMay require changes to BOUT++ upstream to implementrequires xarray changesMay require changes to xarray upstream to implementMay require changes to xarray upstream to implement
Description
If BOUT is changed upstream to write out the global grid point indexes to each file, then xBOUT can use them to infer the order in which the datasets should be concatenated.
This would also require implementing an infer_order_from_coords option in xarray.auto_combine(), as discussed here.
This would move even more of the concatenation logic upstream to xarray, as then we wouldn't need to create a nested list-of-lists anymore, we could just pass the unordered glob of all dump files.
On the other hand this might make the open_mfdataset() call considerably slower, as it will have to read the coordinate variables in order to order the datasets (related discussion here).
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestrequires BOUT changesMay require changes to BOUT++ upstream to implementMay require changes to BOUT++ upstream to implementrequires xarray changesMay require changes to xarray upstream to implementMay require changes to xarray upstream to implement