sync: two more fixes #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First: Following the pattern from coreos/repo-templates, use a hardcoded committer/author identity for the sync commits rather than trying to dynamically fetch it from the GitHub API. GitHub App installation tokens don't have access to the endpoints needed to get app/bot identity information. Second: Fix our sync to sync all of the common files, and handle file deletion. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
jeckersb
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: Following the pattern from coreos/repo-templates, use a hardcoded committer/author identity for the sync commits rather than trying to dynamically fetch it from the GitHub API.
GitHub App installation tokens don't have access to the endpoints needed to get app/bot identity information.
Second: Fix our sync to sync all of the common files, and handle file deletion.
Assisted-by: Claude Code (Sonnet 4.5)