Justfile: Two minor tweaks #1746
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces some nice improvements to the Justfile. The refactoring to use a common base_buildargs variable for podman build commands makes the file cleaner and more consistent. The addition of the clean-local-images target is also a useful utility.
I have one suggestion to make the new clean-local-images target more efficient and concise.
Additionally, this PR removes the build-disk-image, validate-local, and build-disk targets. Since the PR description is empty, it would be helpful to add a brief explanation for these removals to provide more context for reviewers and for future reference.
| podman images --filter "label={{testimage_label}}" | ||
| podman images --filter "label={{testimage_label}}" --format "{{{{.ID}}" | xargs -r podman rmi -f |
There was a problem hiding this comment.
The clean-local-images target runs podman images twice with the same filter. This is inefficient and can be simplified.
The first command displays the images, and the second one pipes the IDs to podman rmi. You can achieve a similar result more efficiently by using the -q (--quiet) flag to get only the image IDs and piping them directly to xargs. The podman rmi command will output the IDs of the images it removes, which provides sufficient feedback to the user.
podman images -q --filter "label={{testimage_label}}" | xargs -r podman rmi -f
To make it easeier to clean things up. Signed-off-by: Colin Walters <[email protected]>
These are dead code. Signed-off-by: Colin Walters <[email protected]>
1 participant
No description provided.