store: Move inner merge commit writing to a helper function #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the merge commit writing logic into a new helper function write_merge_commit_impl. The refactoring is clean and achieves its goal of improving code structure for future work. I have a few suggestions to improve the new helper function's implementation for better clarity and robustness.
cgwalters
force-pushed
the
store-cleanups
branch
from
0f7cc6b to
d49dc03
Compare
No functional changes, prep for further work. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
store-cleanups
branch
from
d49dc03 to
ac08093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, prep for further work.