Add noexcept to destructors to support /Zc:implicitNoexcept-. Fixes #557. #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #636 +/- ##
========================================
Coverage 99.05% 99.05%
========================================
Files 68 68
Lines 6119 6119
========================================
Hits 6061 6061
Misses 58 58
Continue to review full report at Codecov.
|
|
|
jaykrell
added a commit
to jaykrell/iostreams
that referenced
this pull request
Oct 21, 2021
…Noexcept-. Otherwise gets: Error C2694 'override': overriding virtual function has less restrictive exception specification than base class virtual member function 'base' Similar changes are being made e.g.: boostorg/json#636
jaykrell
added a commit
to jaykrell/format
that referenced
this pull request
Oct 21, 2021
/Zc:implicitNoexcept-.
Otherwise gets:
Error C2694 'override': overriding virtual function
has less restrictive exception specification than base
class virtual member function 'base'
Similar changes are being made e.g.:
boostorg/json#636
And proposed here:
boostorg/iostreams#136
I grant there there could be more of this.
These two are just enough for our codebase.
jaykrell
added a commit
to jaykrell/iostreams
that referenced
this pull request
Jul 12, 2024
…Noexcept-. Otherwise gets: Error C2694 'override': overriding virtual function has less restrictive exception specification than base class virtual member function 'base' Similar changes are being made e.g.: boostorg/json#636
jaykrell
added a commit
to jaykrell/format
that referenced
this pull request
Jul 12, 2024
/Zc:implicitNoexcept-.
Otherwise gets:
Error C2694 'override': overriding virtual function
has less restrictive exception specification than base
class virtual member function 'base'
Similar changes are being made e.g.:
boostorg/json#636
And proposed here:
boostorg/iostreams#136
I grant there there could be more of this.
These two are just enough for our codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #557