Feature/quest repository #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Dayeon Lee <[email protected]>
Co-Authored-By: Dayeon Lee <[email protected]>
โฆrotocol Feature/quest repository protocol
Co-Authored-By: Jeonhui Lee <[email protected]>
Co-Authored-By: Dayeon Lee <[email protected]>
Co-Authored-By: Dayeon Lee <[email protected]>
Co-Authored-By: Dayeon Lee <[email protected]>
Co-Authored-By: Jeonhui Lee <[email protected]>
Closed
Co-Authored-By: Jeonhui Lee <[email protected]>
Collaborator
|
๊ณ ์ํ์ จ์ต๋๋ค. merge ๋๋๋ฉด QuestView์ชฝ์ ๋ชจ๋ ๋ ์ด์ด ์ฐ๊ฒฐ์ด ๊ฐ๋ฅํ๊ฒ ๋ค์ :) |
wickedRun
reviewed
Nov 22, 2022
Collaborator
wickedRun
left a comment
wickedRun
left a comment
There was a problem hiding this comment.
๊ณ ์ํ์ จ์ต๋๋น ์๋ดค์๋๋ค.
| switch access { | ||
| case .quests: | ||
| do { | ||
| try ref.collection("quests") |
Collaborator
There was a problem hiding this comment.
collection ์ ๊ทผํ ๋ rawValue๋ ๋ง๋ ๋ณ์๊ฐ์ ๊ฐ์ผ๋ก ์ ๊ทผํด๋ ์ข์ ๊ฒ ๊ฐ์ต๋๋ค.
|
|
||
| do { | ||
| let quests = try realmStorage | ||
| .fetchEntities(type: QuestEntity.self, filter: NSPredicate(format: "date == %@", date.toString)) |
Collaborator
There was a problem hiding this comment.
๊ฐ์ธ์ ์ธ ์๊ฒฌ์ ๋๋ค๋ง ๊ฐ๋ฅํ๋ค๋ฉด NSPredicate๋ค์ enum ์ด๋ struct๋ก predicate์ ๋ํด ์ด๋ฆ์ด ์์ผ๋ฉด ํจ์ฌ ์ฝ๊ธฐ ์ฌ์ธ ๊ฒ ๊ฐ์ต๋๋น. ์๋๋ฉด ํจ์ ๋ด์์ let์ผ๋ก ๋นผ๊ฑฐ๋?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Issue Number
Close #33
๐ ์์ ๋ด์ญ
๐ ์์ ์ ํ
๐ ์ฒดํฌ๋ฆฌ์คํธ
๐ PR ํน์ด ์ฌํญ