Skip to content

Conversation

@Jeonhui
Copy link
Member

@Jeonhui Jeonhui commented Dec 7, 2022

πŸ“• Issue Number

Close #106

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • signUp ν€˜μŠ€νŠΈ λ„€νŠΈμ›Œν¬μ—μ„œ 패치
  • signOut ν€˜μŠ€νŠΈ 둜컬 데이터 μ‚­μ œ

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?
  • μƒˆλ‘œμš΄ ν…ŒμŠ€νŠΈμ™€ 기쑴의 ν…ŒμŠ€νŠΈκ°€ 변경사항에 λŒ€ν•΄ λ§Œμ‘±ν•˜λŠ”κ°€?

μ‹€ν–‰ μ „

스크란샷 2022-12-07 21 06 48

둜그인 ν›„

스크란샷 2022-12-07 21 07 18

λ‘œκ·Έμ•„μ›ƒ ν›„

스크란샷 2022-12-07 21 07 57

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • 둜그인, λ‘œκ·Έμ•„μ›ƒν•œ λ’€ ν™ˆλ·° λ¦¬λ‘œλ”©



@jinwoong16
Copy link
Collaborator

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. 근데 μ „ν¬λ‹˜ 에디터가 인덴트λ₯Ό μ΄μƒν•˜κ²Œ λ¨Ήμ΄λŠ” 것 κ°™λ„€μš”..? 😒

@jinwoong16 jinwoong16 merged commit 495d787 into develop Dec 8, 2022
@Jeonhui Jeonhui deleted the refactor/Repository branch December 8, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignInSignUp Quest Fetch μž‘μ—…

3 participants