Skip to content

add go.mod to test dir #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018
Merged

add go.mod to test dir #16

merged 1 commit into from
Aug 10, 2018

Conversation

dgodd
Copy link
Contributor

@dgodd dgodd commented Aug 7, 2018

an empty go.mod file in the test directory stops go modules from
complaining about the purposely strange file names in the
test fixture directory

an empty go.mod file in the test directory stops go modules from
complaining about the purposely strange file names in the
test fixture
directory
@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files           1        1           
  Lines         223      223           
=======================================
  Hits          187      187           
  Misses         20       20           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c073d...09854d3. Read the comment docs.

@myitcv
Copy link

myitcv commented Aug 7, 2018

Just a drive-by comment here based on a conversation in Slack, but an alternative solution here would be to not commit the test directory structure at all, and instead re-create it as part of the tests.

@myitcv
Copy link

myitcv commented Aug 7, 2018

(sorry, sent that too early)

But this really is an immediate, knee-jerk thought so quite possibly I'm missing lots of history/context in making such a naive suggestion!

@dgodd
Copy link
Contributor Author

dgodd commented Aug 7, 2018

@myitcv I am not the maintainer of this, so I will leave any decisions to others. My two cents is that, for this project, creating the fixture directory from the tests would be very tedious and make the tests harder to read. But again, I leave any such consideration to the maintainers of this repo.

@bmatcuk bmatcuk self-requested a review August 10, 2018 14:18
@bmatcuk bmatcuk self-assigned this Aug 10, 2018
@bmatcuk
Copy link
Owner

bmatcuk commented Aug 10, 2018

Hello, @dgodd. Sorry for the slow reply; I just got back from a long vacation. This looks good to me; thanks for the PR!

@bmatcuk bmatcuk merged commit b91dabe into bmatcuk:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants