Skip to content

Impl TryFrom<fmt::Arguments<'a>> for ArrayString #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

Impl TryFrom<fmt::Arguments<'a>> for ArrayString #170

merged 2 commits into from
Dec 10, 2020

Conversation

@c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Dec 9, 2020 •
edited
Loading

Shortcut for

use core::fmt::Write;
let mut v = Self::new();
v.write_fmt(format_args!("Something -> {}", 123)).map_err(|e| CapacityError::new(e))?;

...

@c410-f3r
Impl TryFrom<fmt::Arguments<'a>> for ArrayString
6dccb48 
Shortcut for

```
use fmt::Write;
let mut v = Self::new();
v.write_fmt(f).map_err(|e| CapacityError::new(e))?;
```
@bluss
Copy link
Owner

bluss commented Dec 10, 2020

Could you add a test for this method?

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Dec 10, 2020

Could you add a test for this method?

Sure!

@bluss bluss merged commit 97c0e74 into bluss:master Dec 10, 2020
@bluss
Copy link
Owner

bluss commented Dec 10, 2020

Thanks

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Dec 10, 2020

Thank you @bluss. You are awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c410-f3r @bluss