Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,6 @@ if (rsp != NULL) {
}
```

## Keeping up to date with note-c repo

This library depends on the Blues [`note-c` library][note-c]. To update this
repo with the latest from `note-c`, run the `update_note_c.sh` shell script
from the `scripts/` folder:

```none
scripts/update_note_c.sh
```

_**NOTE:** It is important to use the script. It utilizes git subtrees to
include the appropriate files in the `src/note-c` folder. It also eliminates
folders that necessary for testing `note-c` individually, but interfere with
the Arduino build environment._

## Documentation

The documentation for this library can be found
Expand Down Expand Up @@ -260,7 +245,22 @@ at the end of the array, and syntax should be as follows,

## Generating a Release

### Update Files
### Update `note-c` dependency

This library depends on the Blues [`note-c` library][note-c]. To update this
repo with the latest from `note-c`, run the `update_note_c.sh` shell script
from the `scripts/` folder:

```none
scripts/update_note_c.sh
```

_**NOTE:** It is important to use the script. It utilizes git subtrees to
include the appropriate files in the `src/note-c` folder. It also eliminates
folders that necessary for testing `note-c` individually, but interfere with
the Arduino build environment._

### Update Version Files

When generating a release of the `note-arduino` library, you will need to update
the version in two places.
Expand All @@ -281,12 +281,13 @@ the version in two places.
version string should follow the form "\<major\>.\<minor\>.\<patch\>" (e.g.
`1.6.4`). This value will be used by the Arduino Library Manager.

### GitHub Release
### Arduino Library Manager Release

Publishing a release on GitHub will trigger the Arduino Library Manager. The
Arduino Library Manager will then look to the `library.properties` file, and
generate a release based on the `version` value it finds there. It should be
noted, the version on GitHub is not evaluated by the Arduino Library Manager.
Arduino Library Manager will look to the `library.properties` file, and generate
a release based solely on the `version` value it finds there.

_**NOTE:** The GitHub version is not evaluated by the Arduino Library Manager._

## More Information

Expand Down
2 changes: 1 addition & 1 deletion library.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name=Blues Wireless Notecard
version=1.6.5
version=1.6.6
author=Blues
maintainer=Blues <[email protected]>
sentence=An easy to use Notecard Library for Arduino.
Expand Down
2 changes: 1 addition & 1 deletion src/NoteDefines.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// Define the version of the `note-arduino` library
#define NOTE_ARDUINO_VERSION_MAJOR 1
#define NOTE_ARDUINO_VERSION_MINOR 6
#define NOTE_ARDUINO_VERSION_PATCH 5
#define NOTE_ARDUINO_VERSION_PATCH 6

#define NOTE_ARDUINO_VERSION NOTE_C_STRINGIZE(NOTE_ARDUINO_VERSION_MAJOR) "." NOTE_C_STRINGIZE(NOTE_ARDUINO_VERSION_MINOR) "." NOTE_C_STRINGIZE(NOTE_ARDUINO_VERSION_PATCH)

Expand Down
10 changes: 8 additions & 2 deletions src/note-c/n_helpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -529,8 +529,14 @@ const char * NoteBinaryStoreTransmit(uint8_t *unencodedData, uint32_t unencodedL
return err;
}

// Issue a "card.binary" request.
J *rsp = NoteRequestResponse(NoteNewRequest("card.binary"));
// Issue a "card.binary" request. The length is reset if this is the
// first segment, clearing out any error that might potentially be
// pending from a previous use of the binary store.
J *req = NoteNewRequest("card.binary");
if (notecardOffset == 0) {
JAddBoolToObject(req, "reset", true);
}
J *rsp = NoteRequestResponse(req);
if (!rsp) {
const char *err = ERRSTR("unable to issue binary request", c_err);
NOTE_C_LOG_ERROR(err);
Expand Down
Loading
Loading