Skip to content

Separate out "appendix" material? #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gwd opened this issue Sep 16, 2020 · 1 comment · Fixed by #19
Closed

Separate out "appendix" material? #18

gwd opened this issue Sep 16, 2020 · 1 comment · Fixed by #19

Comments

@gwd
Copy link
Contributor

gwd commented Sep 16, 2020

Similar to #16: git format-patch often adds stuff after a --- line; and many people add things there too. So you might have a message that looks like this:

Subject: [PATCH] Implement foo bar

Blah blah blah

S-o-b: <[email protected]>
---
CC: [email protected]
CC: [email protected]

 xen/common/domain.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

git am always ends up removing anything after the ---, because it actually interprets --- as the beginning of the patch.

Would you be open to having PatchPatchHeader separate out this extra information into a separate field? Maybe, BodyAppendix or something like that?

If so I can write something up & send a PR.

@bluekeyes
Copy link
Owner

This sounds reasonable to me: for email formatted preambles, split the body at the first --- and store everything after in BodySuffix.

@bluekeyes bluekeyes linked a pull request Sep 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants