Fix display of private names in the TS Language Server #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheiber
reviewed
Oct 9, 2018
| } | ||
| let firstChar = symbolName.charCodeAt(0); | ||
| const canUsePropertyAccess = isIdentifierStart(firstChar, languageVersion); | ||
| const canUsePropertyAccess = firstChar === CharacterCodes.hash ? |
There was a problem hiding this comment.
Probably best to check the name node itself rather than rely on checking for #. Something like:
isNamedDeclaration(symbol.valueDeclaration) ? isPrivateName(symbol.valueDeclaration.name)
There was a problem hiding this comment.
I think I have to use the symbol name because apparently valueDeclaration can be undefined. Making the change to check isNamedDeclaration(valueDeclaration) crashes tons of tests because it's undefined.
mheiber
force-pushed
the
es-private-fields
branch
from
c493238 to
9767522
Compare
added 2 commits
December 10, 2018 11:05
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
joeywatts
force-pushed
the
private-name-server-display
branch
from
72285d1 to
3fc3756
Compare
mheiber
approved these changes
Dec 10, 2018
Neuroboy23
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language server was displaying private names in the form of
A[#privateName]instead ofA.#privateName. (One place where this is visible is when you hover over a private name in VSCode.) This change to the checker will use the property access with private names instead of element access.