Skip to content

Conversation

@chris8736
Copy link
Contributor

@chris8736 chris8736 commented Jan 4, 2021

Added week outlines and homework solutions without pictures / explanations (which I have in a separate doc for now).

Closes: #49

add week outlines and homework solutions without pictures / explanations
@lazyplatypus
Copy link
Member

Hey @chris8736, all prs need to be associated with an issue. can you mention in your PR description what issue this would be closing?

@chris8736
Copy link
Contributor Author

Got it, edited.

@chris8736 chris8736 changed the title Add outline markdowns Week 6 and 7 Material (Game Dev) Jan 7, 2021
@lazyplatypus lazyplatypus requested a review from emsesc January 9, 2021 04:45
Copy link
Collaborator

@emsesc emsesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great organization and content! My only comment is to add more formatting so it's easier to read. I added comments throughout to suggest some edits.

@@ -0,0 +1,5 @@
Now, what I’d like for you to do this week is to find some sound assets of your own, either using the websites I’ve shown you, some other source, or even your own recording. Even though we’re not working on this project commercially, be aware of the audio’s licensing as you’re searching. Ideally, get one background music track, and two sound effects for jumping and crashing. Add them to the project folder and integrate them into this game!

For further mastery of audio:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the bulleted formatting! However, you have to put a space between "-" and your content in order for it to show as bullet points. Try using the preview button shown below to preview what your file looks like in rich format!

image

@@ -0,0 +1,5 @@
Now, what I’d like for you to do this week is to find some sound assets of your own, either using the websites I’ve shown you, some other source, or even your own recording. Even though we’re not working on this project commercially, be aware of the audio’s licensing as you’re searching. Ideally, get one background music track, and two sound effects for jumping and crashing. Add them to the project folder and integrate them into this game!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this more concise by making it a bulleted todo list?

Hey all, today we’ll be looking at how to put sounds in your Unity projects. I’ll be going over how to play sounds through code, how to adjust those sounds in Unity, and how to find and best use free sound assets online.

Now, hopefully you’ve already downloaded and opened the same project I have in front of me, which you can find and download at this github link: https://github.com/chris8736/bit_temp_mds/tree/main

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here with the bullet points. Use the "preview" option to see how the markdown works, and here's a cheatsheet on how to use markdown! (it's kind of like a formatting coding language)

@@ -0,0 +1,30 @@
Outline:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make "Outline:" a title (refer to https://www.markdownguide.org/cheat-sheet/)

Audio Source basics (5 mins)
-create an Audio Source component with clip
-play with values during runtime
Component Referencing (5 mins)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These section headers would benefit from being bolded or changed to a header https://www.markdownguide.org/cheat-sheet/

@@ -1 +1,126 @@
Audio Source basics (5 mins)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to my previous comments about formatting :)

@@ -1 +1,109 @@
Put your script here.
Particle System basics (10 mins)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome content, but can you make it more readable? I know it's a script though, so that may be more challenging. Maybe split it into sections?

Copy link
Collaborator

@emsesc emsesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris8736 the formatting looks awesome! Looks good 👍

@emsesc emsesc merged commit e253bcc into bitprj:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Implement Weeks 6 and 7 of GameDev BitCamp

3 participants