Fix pagination of transaction history #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for taking a look at this. I'm currently working in this area with #422 (line 517 of lib/services/bitcoind.js) and txids are reversed and then sliced and this shouldn't be an issue there. Also, this issue looks related: bitpay/insight-api#471 |
Contributor
Author
|
Sure! Do you expect any more releases of bitcore-node with static bitcoind? The work on #422 looks awesome, but we hoped this patch could be pushed to upstream early. There's a bitcore branch of mytrezor.com ready, and we wanted to offer users more than one choice of a backend server. |
Contributor
|
Sounds good to me! There are a few other fixes that could be useful in a patch release. |
Contributor
|
Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if paging i.e. from 0 to 100,
toOffsetcould easily get negative (because the user does not know thetotalCountin advance). This should fix this case.