Bitcore node in the user-agent (subversion) #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kleetus
commented
Aug 13, 2015
kleetus
commented
- There is a comments section that can be used in the FormatSubVersion string for the user agent that is exchanged between peers
- The comments section allows arbitrary strings to be added per the client
- This is the most appropriate place to include the bitcore-node message
- A string similar to: "/Satoshi:0.11.0(bitcorenode)/" will be passed as a response to getpeerinfo or getnetworkinfo
kleetus
changed the title
- There is a comments section that can be used in the FormatSubVersion string for the user agent that is exchanged between peers - The comments section allows arbitrary strings to be added per the client - This is the most appropriate place to include the bitcore-node message - A string similar to: "/Satoshi:0.11.0(bitcorenode)/" will be passed as a response to getpeerinfo or getnetworkinfo
kleetus
changed the title
kleetus
changed the title
Contributor
|
LGTM |
pnagurny
added a commit
that referenced
this pull request
Aug 17, 2015
Bitcore node in the user-agent (subversion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.