Skip to content

Conversation

weblate
Copy link

@weblate weblate commented Aug 28, 2025

Translations update from Hosted Weblate for cert4android/lib.

Current translation status:

Weblate translation status

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ArnyminerZ
ArnyminerZ previously approved these changes Sep 1, 2025
@rfc2822
Copy link
Member

rfc2822 commented Sep 1, 2025

Weblate commits translations with the author name. This causes the CLA assistant to require signing the CLA for the Github PR. However the CLA has already been signed at Weblate.

So I wonder whether we should/can disable the CLA for PRs only from Weblate.

Update: I have exempted PRs by @weblate from the CLA assistant.

ArnyminerZ
ArnyminerZ previously approved these changes Sep 4, 2025
sunkup
sunkup previously approved these changes Sep 8, 2025
@rfc2822
Copy link
Member

rfc2822 commented Sep 8, 2025

I wonder whether every single contributor causes the CLA assistant to fail. I think there's also an option on Weblate to control which email addresses are used to commit, right?

@sunkup
Copy link
Member

sunkup commented Sep 8, 2025

Yes, true! I just updated mine to the bitfire email address.

@weblate weblate dismissed stale reviews from sunkup and ArnyminerZ via e25c2eb September 26, 2025 16:02
rfc2822 and others added 6 commits October 4, 2025 08:35
Currently translated at 100.0% (15 of 15 strings)

Translation: cert4android/lib
Translate-URL: https://hosted.weblate.org/projects/cert4android/lib/de/
Currently translated at 100.0% (15 of 15 strings)

Translation: cert4android/lib
Translate-URL: https://hosted.weblate.org/projects/cert4android/lib/ca/
Currently translated at 100.0% (15 of 15 strings)

Translation: cert4android/lib
Translate-URL: https://hosted.weblate.org/projects/cert4android/lib/pl/
Currently translated at 100.0% (15 of 15 strings)

Translation: cert4android/lib
Translate-URL: https://hosted.weblate.org/projects/cert4android/lib/da/
Currently translated at 100.0% (15 of 15 strings)

Translation: cert4android/lib
Translate-URL: https://hosted.weblate.org/projects/cert4android/lib/uk/
Currently translated at 100.0% (15 of 15 strings)

Translation: cert4android/lib
Translate-URL: https://hosted.weblate.org/projects/cert4android/lib/sk/
@weblate weblate force-pushed the weblate-cert4android-lib branch from e25c2eb to d3bcc0d Compare October 4, 2025 08:35
@weblate weblate requested a review from a team as a code owner October 4, 2025 08:35
@rfc2822
Copy link
Member

rfc2822 commented Oct 4, 2025

BTW we can actually just merge the PR even when CLA says "not all requirements met"

So if we make sure the CLA is on Weblate, we can just merge these PRs, right?

@sunkup
Copy link
Member

sunkup commented Oct 6, 2025

So if we make sure the CLA is on Weblate, we can just merge these PRs, right?

Sounds reasonable, yes. It's kind of a annoying, but I don't see a problem with it when users sign the CLA at weblate anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

7 participants