ci: automated update to rustc 1.88.0 #280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-pr-actions[bot]](https://avatars.githubusercontent.com/u/62867074?s=80&v=4){kind=small}
Pull Request Test Coverage Report for Build 16281556337Details
💛 - Coveralls |
2 tasks
notmandatory
added a commit
that referenced
this pull request
Jul 31, 2025
d75126e clippy: allow `uninlined_format_args` (valued mammal) cbf0cfe chore: update rust-version to 1.88.0 (valued mammal) aa53cc1 clippy: fix uninlined format args (valued mammal) Pull request description: Fix #281 by taking clippy's suggestion to inline the arguments to a `format!` string where applicable. Also update `rust-version` to 1.88.0, closing #280. ### Notes to the reviewers I've gone ahead and fixed the clippy warnings, although some have argued that the lint is quite pedantic and not entirely helpful when it comes to style and readability. Therefore I also allowed the lint to prevent clippy from warning about it in the future d75126e. That change can be reverted if/when rust lang moves `uninlined_format_args` back to the pedantic, i.e. not default group of lints rust-lang/rust-clippy#15287. ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [ ] ~~This pull request breaks the existing API~~ ACKs for top commit: notmandatory: ACK d75126e oleonardolima: ACK d75126e Tree-SHA512: c34e701fb08f6ada2b0f34c87c93417ca966b021360fa787563f00c6968444028a876bfaf6952cf468f8ad834556b784002d4fc7fd09886fc7420ff1cb6eff9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated update to Github CI workflow
cont_integration.ymlby create-pull-request GitHub action