Skip to content

More tests for bdk_electrum fee calculation #1444

@evanlinjin

Description

@evanlinjin

PR #1443 identified a large oversight when we added the new feature of including prev txouts for fee calculation.

I propose a separate test specific to testing fee calculation that takes into account what @ValuedMammal mentioned in #1443 (comment):

In the integration test for electrum the outpoint we're looking for will always have a vout of 0 (they are coinbase txs), so calculating the fee of the received tx happens to work by sheer luck. A more robust test would involve controlling the utxo spent by Core and in which order it appears in the tx which is posing more of a challenge.

Originally posted by @evanlinjin in #1443 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions