Reduce stack allocation in CBF #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
i built swift bindings from this pr branch locally and then pointed to them in BDK iOS app and ran the iOS app on a simulator with a kyoto wallet, no crash. |
9 tasks
rustaceanrob
force-pushed
the
10-10-kyoto-patch-release
branch
from
6a73e6b to
9c271a4
Compare
rustaceanrob
force-pushed
the
10-10-kyoto-patch-release
branch
from
9c271a4 to
624655c
Compare
Collaborator
Author
|
624655c built and ran locally |
reez
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #877
The
CbfNodewas attempting to allocate a large section of the stack memory, and Swift denied doing so. Reducing this allocation in Kyoto has resolved the issue locally for me.